Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes "double paren" issue for boolean / if function #3259

Merged
merged 5 commits into from
Jul 10, 2018
Merged

Removes "double paren" issue for boolean / if function #3259

merged 5 commits into from
Jul 10, 2018

Conversation

matthew-dean
Copy link
Member

@matthew-dean matthew-dean commented Jul 4, 2018 •
edited
Loading

See tests, allows more intuitive form for simple conditions:

  @f: boolean(3 = 4);
  f: if(not(@f), 6);
  g: if(true, 3, 5);
  h: if(false, 3, 5);

Note: multiple conditions still require parens around conditions without refactoring e.g.

if ((true) and (true), 3, 5);

EDIT: this is now fixed. You can write:

if (true and true, 3, 5);

@matthew-dean matthew-dean reopened this Jul 8, 2018
@matthew-dean
Copy link
Member Author

This is low risk and pointed out at the time of implementation as a flaw, so I'll just merge.

@matthew-dean matthew-dean merged commit 85e64ce into less:master Jul 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seven-phases-max seven-phases-max Awaiting requested review from seven-phases-max

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@matthew-dean